Link to fixed tag for source links#16883
Open
mkniewallner wants to merge 1 commit intorust-lang:masterfrom
Open
Link to fixed tag for source links#16883mkniewallner wants to merge 1 commit intorust-lang:masterfrom
mkniewallner wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
samueltardieu
requested changes
Apr 21, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16882.
Make the "View Source" links point to a fixed tag version when
TAG_NAMEenv var is set (which is the case in the release workflow) instead of always linking tomaster.Test plan
Tested locally with both:
Links point to
https://github.com/rust-lang/rust-clippy/blob/rust-1.95.0/...in the first case, andhttps://github.com/rust-lang/rust-clippy/blob/master/...in the second one.changelog: none